[MERGE] Refactor commit to prepare for population by tree walking

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
>> iter_changes *always* tells you whether a file is currently versioned,
>> so there's no reason to stick an unversioned file in deleted_ids.
> 
> That's good to know. I expected as much and only added this block of
> code when 2 unit tests failed to pass without it. :-( I'll dig deeper ...

To be more direct, if versioned_flags[1] is False, you do not need to
unversion it.

> Thanks for the feedback. The reason I think iter_commitable is warranted
> earlier is because iter_changes doesn't provide me the SHA value

iter_changes is designed to not need to calculate SHA values 99% of the
time, so it doesn't provide a SHA value.  All it should need is a stat,
especially with dirstate.

> The
> CommitBuilder code needs the SHA value in order to test for some special
> cases - 'changed' isn't enough.

That doesn't sound right to me.  I can see how it would want the SHA in
order to record it, but not in order to test for special cases.  Could
you explain further?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGjNnk0F+nu1YWqI0RAmuhAJ4jUABwK6ik7bdFWGMazOx6lUI0YwCfQDRR
0R/WEW0cmrEq1bjNH5vHxps=
=9Zc3
-----END PGP SIGNATURE-----