Incorrect unicode handling

[Goffredo Baroncelli]

Hi Vasily

On Wednesday 04 July 2007, you (Vasily Sulatskov) wrote:
> Hi Goffredo,
> 
> I will gladly provide tests, but I am having problems figuring out how
> to run tests.
> 
> Is "bzr selftest" a only way to run tests? It takes too much time to
> run bzr selftest on my machine.
> 
> Could you provide some pointers?
> 

you can specify which test you want to perform. For examples

   ghigo at venice:~$ bzr selftest webserve
       bzr: /home/ghigo/bazaar/bzr.dev/bzr
    bzrlib: /home/ghigo/bazaar/bzr.dev/bzrlib

   [37/37 in 9s]    bzrlib.plugins.webserve.test_webserve.TestW....
   -----------------------------------------------------------------
   Ran 37 tests in 9.695s

   OK
   tests passed
   ghigo at venice:~$


so you can perform only the tests related to webserve. In any case "bzr help 
selftest" will give you all the info.


> Or will it be enough to create a project that will demonstrate
> encoding problems with bzr webserve?

If you want to write a test case, that is very good. In any case an'example is 
a good start point.


Moreover, I am reviewing  your patch, and I am inclined to accept it. The only 
change that I want is to put in the config file/command line the encoding of 
the files content and the encoding of the html page. 

So we can have cp1251 as encoding of the file content and iso8859-1 as 
encoding of the html file...

Finally, what is the meaning of

     if isinstance(s, str):
         r = s.replace('@', '@')
     else:
         r = s.replace(u'@', u'@')

can the lines above be replaced by ?

     r = s.replace("@", "@") 





> 2007/7/3, Goffredo Baroncelli <kreijack at tiscalinet.it>:
> > Hi Vasily,
> >
> > regarding the bug https://bugs.launchpad.net/bzr-webserve/+bug/96853, 
could
> > you provide me some test case ?
> >
> > TIA
> >
> > Goffredo
> >
> >
> >
> > --
> > gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) 
<kreijack at inwind.it>
> > Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
> >
> 
> 
> -- 
> Vasily Sulatskov
> 



-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bazaar_utf8.diff
Type: text/x-diff
Size: 6471 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070705/c27f1b65/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070705/c27f1b65/attachment.pgp