[0.18][#109169][merge] add lock debugging, remove unnecessary lock peeks

[Robert Collins]

On Wed, 2007-07-04 at 10:05 +1000, Martin Pool wrote:
> > There doesn't seem to be a patch to review. But I'm fine with removing .wait()
> > in favor of .attempt_lock()
> 
> Sorry, here it is.  I'll post an additional patch which removes wait.

+1 conditional.

As long as you've considered these points I'm in favour of merging it.

_lock_core is a rather ugly name. Sure its at the core, but what does it
do? What is it responsible for?

Why not create brokenrename transport and server within the test module?
Its testing code, and you even have a comment that you don't want it to
be required to pass the transport conformance tests.

Why not just use delete_tree rather than trying, failing and trying
again? The smart server does delete_tree in a single round trip (even on
older versions) rather than many, and its possible webdav etc can do
that too in future.

I note that you still double-peek - why is that ?

I think you should record 'Dlocks' in debug.py.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070704/6d93ee2b/attachment.pgp