[0.18][#109169][merge] add lock debugging, remove unnecessary lock peeks

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Here is an updated version in response to feedback from John and
> Robert.  The scope has broadened.
> 
> * Add -Dlock trace support
> * Fix https://bugs.launchpad.net/bzr/+bug/118715 that causes many
> directories to be left behind when we fail to take a lock
> * Add a Transport simulator for servers that do rename(a,b) as
> rename(a, a/b), as bazaar.launchpad.net once did, and a test that we
> handle this correctly; also make unlocking more robust in this case.
> * Some general refactoring of LockDir
> * assertContainsRe gives a better failure message
> * tests for locking by token
> 
> Because this fixes a high-severity bug I'd like to land it for 0.18.
> 
> Also a question: we currently have LockDir.wait, which waits for the
> object to be unlocked but does not take the lock.  This does not seem
> very useful, because there is no guarantee that it is still unlocked
> by the time you do anything with it.  I think I added it for the test
> suite, which is the only place where it's called.  Any objections to
> removing it in a later patch?
> 

There doesn't seem to be a patch to review. But I'm fine with removing .wait()
in favor of .attempt_lock()

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGiqyoJdeBCYSNAAMRAh3YAJ0SFL8dw9npzIMEA1aC2oLXKaZszQCgw3FS
h8KCp5n1ARFS++PND5P/GAM=
=3vsU
-----END PGP SIGNATURE-----