[RFC] Blank lines at the end of files

Martin Pool mbp at sourcefrog.net
Fri Jun 29 07:11:38 BST 2007


On 6/29/07, Andrew Bennetts <andrew at canonical.com> wrote:
> John Arbash Meinel wrote:
> >
> > I've noticed Aaron comment on blank lines at the end of files. I wasn't
> > aware that it was a strict requirement/anything we have ever discussed.
> >
> > Obviously Aaron feel like they shouldn't be there. I don't really care.
>
> I basically don't care.  I've never seen their presence or absence have any
> significant effect on anything.  In my own code I tend to have them, but out of
> habit rather than for a reason.
>
> I can't see a reason for caring either way, so I can't see a reason to even
> standardise on whether not they should be there.  It just doesn't matter AFAICT,
> so I'd be happiest not caring about it (both as a developer and as a reviewer).
> That is, not only do I not mind if we have them or not, I don't mind if we're
> inconsistent.

I don't care much about them either.  I use vim so it's visible if
they're there.  I do tend to trim them, but on the other hand I would
probably be slightly unhappy if a patch was knocked back only because
it had trailing newlines.

-- 
Martin



More information about the bazaar mailing list