[MERGE] refactor of find_previous_heads from inventory to repository
robertc at robertcollins.net
Fri Jun 29 06:06:47 BST 2007
On Fri, 2007-06-29 at 12:16 +1000, Ian Clatworthy wrote:
> Part of the commit refactoring work driven by the design notes put
> together by Martin and Robert in doc/developers/commit.txt.
Hmm, this looks a little strange. Why is it not a Repository method?
Also, I had thought that you'd be splitting the method into two: gather
the revision_ids to find heads amongst from the inventory (which is
inventory specific code), and secondly find the heads for (file_id,
Be nice to have a NEWS entry on the API changes that should happen as a
result of this; and also tests!
Tests should be migrated or created when moving code to a new home -
often I migrate, but if the old api is staying around I will duplicate
the portion of the tests testing the home, and try to remove that from
the tests for the old home.
-1 on this at the moment.
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070629/c0db8cdc/attachment.pgp
More information about the bazaar