[MERGE] Show commit hook names during commit.

Martin Pool mbp at sourcefrog.net
Fri Jun 29 01:08:36 BST 2007


On 6/29/07, Robert Collins <robertc at robertcollins.net> wrote:

> > Which would generally be short, and indicate it wasn't explicitly named.
>
> >>> foo = lambda x:x
> >>> foo.__name__
> '<lambda>'

And do hooks actually register lambdas?  I realize it's possible but
it seems odd...

> > Regardless, I would rather see:
> >
> >  Running post commit hooks [unknown]
> >
> > Than
> >
> >  Running post commit hooks [No hook name]
>
> I'm happy to change it to unknown. Being explicit about it seemed nicer
> to me than just 'unknown' though. Straw poll time - is 'unknown' or 'no
> hook name' clearer?

Since you ask, I think the second is clearer - bazaar knows what hook
it's running, it just doesn't know a name for it. :-)  But as I said
before, I would personally rather display the callable's module and
name.

In summary I agree with John but let's not bikeshed...

-- 
Martin



More information about the bazaar mailing list