[MERGE] Bug #122656: better error message for bzr ann 'doesn't exist'

James Westby jw+debian at jameswestby.net
Thu Jun 28 21:53:43 BST 2007


On (28/06/07 16:06), Aaron Bentley wrote:
> ^^^ Please indent using four spaces.
> 
> I would recommend trying to avoid multi-line strings.  e.g.
>                 if file_id is None
>                     raise errors.BzrCommandError("The file '%s' is not"
>                         "present in the specified revision" % relpath)
> 
> You should use filename rather than relpath, so that the filename shown
> is relative to the user's cwd.

All done in the attached bundle.

> 
> Also, your merge requests are not being auto-tracked by Bundle Buggy
> because your merge directives are in the message body, rather than an
> attachment.  This means I must do extra work to manage the
> pending-request list.  I'd appreciate it if you would attach your merge
> directives rather than sending them in the message body.  (The --mail-to
> and --message options are intended for use with PQM)
> 

Apologies for that.

I think it would be great if we could have a command that submitted
bundles like merge-request, but as you desire, it makes the submission a
little easier, and personally that small difference makes it easier to
contribute. Perhaps dato's email work will make this easier.

Thanks,

James

-- 
  James Westby   --    GPG Key ID: B577FE13    --     http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256
-------------- next part --------------
A non-text attachment was scrubbed...
Name: annotate.diff
Type: text/x-diff
Size: 5533 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070628/1fd2f4f5/attachment-0001.bin 


More information about the bazaar mailing list