[PATCH][BUG 119330] Fix tempfile permissions error in smart server tar bundling (under windows)

[Martin]

On 08/06/07, Martin _ <gzlist at googlemail.com> wrote:
> Attached patch is fix for second half of issue with trying to get
> bzr+http working under windows/mod_python, see lauchpad for gory
> details:
> https://bugs.launchpad.net/bzr/+bug/119330
>
> Rather than re-opening tempfile from filename in order to use it as
> tempory tar.bz2 to pack and  send repo to client, patch passes file
> reference. Windows throws a permissions error otherwise when
> attempting to get second write access, for reasons I don't (and don't
> want to) fully understand. This probably wants checking over for nix
> (and other) implications before applying.
>
> Martin

Someone might want to look at this at some point. Improves the test
suite summary from:

FAILED (failures=25, errors=13, known_failure_count=1)
638 tests skipped

To with patch applied:

FAILED (failures=11, errors=12, known_failure_count=1)
644 tests skipped

The skipped count is a bit odd, the tests test_generate_docs (2) and
test_version.TestBzrlibVersioning (1) seem to have fluked past on the
first run, and the main area of change,
bzrdir_implementations.test_bzrdir.TestBzrDir improves from
11FAIL/80skip/340 to 83skip/340 with the rest passing.

Fixing the broken test suite tempory file unlinking would make life much easier.

Martin