[MERGE] cleanup blackbox tests

John Arbash Meinel john at arbash-meinel.com
Tue Jun 26 17:09:18 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "john" == John Arbash Meinel <john at arbash-meinel.com> writes:
> 
>     john> John Arbash Meinel has voted +1.
>     john> Status is now: Approved
>     john> Comment:
>     john> I didn't review all of the changes, assuming that the test_*
>     john> changes were mostly mechanical.
> 
> They weren't, I reviewed the patch and was interested, so I
> dug and already have two other patches on top of this one that
> I'd like Martin to have a look at, don't merge too quickly.
> 
> Many files are already concerned, as it's cleaning, let's do it once.
> 
>      Vincent

Well, if you are going to help cleaning, then try to switch away from the
varargs form. It should be simple enough to wrap them with [].

I would be surprised if changing run_bzr_captured => run_bzr() would not be
mechanical, but maybe he looked into doing other things, too.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGgTotJdeBCYSNAAMRAurhAJ4yAJ46GzA89eT5jQ7Jv7VeaKqS9QCeNzjW
9aWaV3RflTuveti2Tg7JjOM=
=Xj70
-----END PGP SIGNATURE-----



More information about the bazaar mailing list