[MERGE] Make typing 'bzr' under win98 do something useful

John Arbash Meinel john at arbash-meinel.com
Tue Jun 26 15:19:37 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin wrote:
> On 20/06/07, Alexander Belchenko <bialix at ukr.net> wrote:
>> It's a known problem since 2005.
> 
> Right, this is the core point really, rather than waiting more years
> for a big patch that corrects, works around, or just notifies of all
> the unixy assumptions in the code, I think it's better to add a short,
> prominent note now. Then when/if the big patch is ready, it's not hard
> to chop those couple of lines back out at the same time.

Assuming that you have shared file-level locks isn't exactly a "unixy assumption".

That said, if there is reliable win98 detection, we could just have format
- --knit stay the default there, and not issue upgrade requests.

You could even do it in a "win98" plugin that just set the default WT format,
and set WorkingTreeFormat3.upgrade_recommended = False.

The sum total of the code is something like:

from bzrlib import workingtree
workingtree.WorkingTreeFormat3.upgrade_recommended = False
fmt3 = workingtree.WorkingTreeFormat3()
workingtree.WorkingTreeFormat.set_default_format(fmt3)


Put that in C:\Python2X\Lib\site-packages\bzrlib\plugins\win98.py

And it will default the working tree to format 3 and not bother you about it.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGgSB4JdeBCYSNAAMRAj+zAJ0SQRWmjDzdISfZO6mi5g5ILNY7wgCeIxxf
FptcdsqeL7AlAg/QQyB24yY=
=F7/i
-----END PGP SIGNATURE-----



More information about the bazaar mailing list