ensuring commit has enough tests...

[Robert Collins]

On Tue, 2007-06-26 at 12:03 +1000, Martin Pool wrote:
> On 6/26/07, Robert Collins <robertc at robertcollins.net> wrote:
> > Ian expressed to me the thought that with the overhaul needed of commit,
> > it would be good to expand test coverage there.
> 
> That's a good idea - also there are some old and hairy tests that
> could do with a haircut.
> 
> At a higher API level we would also want to test-
> 
> * That committed changes are reported properly, including file
> deletion and renames
> * Invoking the message editor, if not message is given
>   - Commit is aborted if no message is entered

I think these are part of the same API - reporting of changes should be
done as we record, so this is just checking the output side of the API.
Likewise commit abortion (which I think is already checked)

> > user path selection:
> >  - whole tree
> >  - subtree that isn't modified though the subtrees before and after are.
> >  - subtree that is modified
> >  - subtree that includes renames (against basis)
> >    - into, lexically before and after
> >    - out of, lexically before and after
> >  - subtree that includes renames (against pending merge):
> >    - into, lexically before and after
> >    - out of, lexically before and after
> 
> also,
>   - giving a path that's not versioned should be an error
>   - but it's ok if it used to be versioned (and is now deleted)

Right.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070626/159d04ea/attachment-0001.pgp