[merge] knit index robustness/corruption?

[Martin Pool]

I have, for some reason, a knit file with an incorrect index record.
It does not look like the kind of problem that originated in Bazaar,
so I suspect perhaps a network or even hardware error.  I have had a
couple of hard crashes on this  machine is recent weeks.

The line in question, 4751, is in the middle of the file, pretty old,
and in between other correct records.

 4747 mbp at sourcefrog.net-20060504023547-6ff07ce73c778717 fulltext
1721506 352 4743 :
 4748 mbp at sourcefrog.net-20060504024031-82abe45d799c9350 fulltext
1721858 374 4744 :
 4749 mbp at sourcefrog.net-20060504033443-abe6c9e566087691 fulltext
1722232 411 4745 4719 :
 4750 mbp at sourcefrog.net-20060504065938-0e2871ad0d76f3a2 fulltext
1722643 394 4746 4716 :
 4751 pqm at pqm.ubuntu.com-20060504081215-e807a459c8bcb379 fulltext
1723037 423 471v 4747 :
 4752 robertc at robertcollins.net-20060428055433-be86bc92d5efd816
fulltext 1723460 387 4688 :
 4753 robertc at robertcollins.net-20060504013148-74208691b1b4857e
fulltext 1723847 374 4749 :
 4754 robertc at robertcollins.net-20060504061106-dea34f7ad6b4855a
fulltext 1724221 377 4750 :
 4755 robertc at robertcollins.net-20060504083932-009bfa89993005aa
fulltext 1724598 374 4751 :
 4756 robertc at robertcollins.net-20060504101340-18fa61cb9cf268fb
fulltext 1724972 376 4752 :
 4757 robertc at robertcollins.net-20060504103613-bf4d13f925aa8520
fulltext 1725348 380 4753 :

It is correct in a freshly pulled repository.

In general knits are meant to just skip truncated index records.  I'm
not sure they should silently skip incorrect records, but it's
probably good to at least make it possible to read the file.

This probably needs to be tested by having an example of a knit file
which is disturbed in this way, but I thought I'd get comments on the
patch itself first.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20070625-knit-index-robustness.diff
Type: text/x-patch
Size: 1197 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070625/d7195613/attachment.bin