[MERGE] An SMTPConnection class for bzrlib

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Adeodato Simó wrote:
>> Responsibility for preventing a traceback should be taken at a higher
>> level, not here.
> 
> Well, the problem is that, as I see it, the upper level can't really
> prevent the error from happening, because it can't know in advance what
> the SMTP server will react with an error code to.

I didn't mean to imply that the upper layer would prevent the error,
just the traceback.

> With this, I can't see how this is an internal error.

I tend to think that everything is an internal error until it's proven
to be user error.

> If it's an internal error, every call to send_email() has to catch
> SMTPError, and wrap it into a BzrCommandError or whatever appropriate;

*after properly determining that this is not some kind of internal error*

> Is my point clear (even if you don't agree)?

Your point is clear, and this appears to be something that reasonable
people may disagree on, so if you want to make it a non-internal error,
go ahead.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGeHg80F+nu1YWqI0RAp5AAJ49sWWuVQEL9126mzSXyUHV/suXYQCgiIUA
4CxvM2WA4MhFsn4iG1ZpnF8=
=Ydqj
-----END PGP SIGNATURE-----