[MERGE] An SMTPConnection class for bzrlib

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> I think it is entirely reasonable for "AuthenticationFailure" to be raised from
> here without a full traceback. Otherwise any command that wants to send an
> email needs to trap it and re-raise a BzrCommandError.

Well, perhaps I'm overreacting.  Right now we're too biased towards
non-internal errors, and when people report a bug it's a bloody pain.
Unless we're sure that something is user error, I think we should be
generating a traceback.

> While we *can* trap and re-raise, it breaks the tracebacks. Which often is a
> problem when we *think* we are handling an exception properly, but turn out to
> be wrong.

I think it's much more common that we're not handling an error at all
than handling it badly.

> I suppose a different possibility would be to have the wrapping code log the
> current traceback, and then re-raise. (I *really* appreciate our
> always-log-the-traceback code when users have problems on IRC).

I think that's because *way* too many errors are failing to generate
errors on the commandline.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGeHcr0F+nu1YWqI0RAnC6AJ4l3tzuTfmhFBwhaxmrZLVfo8sqgwCfV5xX
+p+g4r7yZqneWF8fOEnDF0A=
=C/2j
-----END PGP SIGNATURE-----