[MERGE] An SMTPConnection class for bzrlib
Aaron Bentley
aaron.bentley at utoronto.ca
Tue Jun 19 21:27:44 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John Arbash Meinel wrote:
> Adeodato Simó wrote:
>> Small fix added.
>
>> P.S.: Is it okay to send partial bundles, or resending the whole thing
>> is preferred? Thanks.
>
>
>
> I'm okay with it when it is a simple follow up like this. So it is obvious what
> the parent patch is.
>
> I think the preferred method is to send a small diff, and a full bundle. I
> think for a trivial fix like this, it is a bit overkill to send a full bundle,
> because it actually makes it hard to see what small change was made.
The thing is, no one has reviewed the previous version. And now that
there's a new version, It makes more sense to review the new one. But
since there's no diff of the new one, I can't review the revised one as
a whole.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGeDxA0F+nu1YWqI0RAgGbAJ9qVQ+49XBh1czXGzy8R/keH8YhywCfQiFD
WCFveY+3IYgiXTYbKsSH3cI=
=uy/V
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list