[MERGE] handle null revision properly for LCA

Aaron Bentley aaron.bentley at utoronto.ca
Tue Jun 19 15:57:33 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

The new Graph methods require that the null revision be expressed as
'null:' not None.  Using None has turned out to be a bad idea in our
APIs, so I propose that all new APIs accept only 'null:'.

This patch fixes input to find_unique_lca, so that it doesn't get None.
 Previously, it would go into an infinite loop if None was provided.
This patch prevents infinite looping-- it raises an exception instead.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGd+7d0F+nu1YWqI0RAo40AJ9wHU/3Wr46zG/G4Gg3mcaPO9/RiwCfbc/1
8Fbxt3OjXJn6JiXX0DCc66c=
=2l8B
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lca-null-revision.patch
Type: text/x-patch
Size: 27649 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070619/b0ed512b/attachment-0001.bin 


More information about the bazaar mailing list