[MERGE] Container format basic implementation

Aaron Bentley aaron.bentley at utoronto.ca
Fri Jun 15 16:24:22 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Or alternatively, if ContainerReader demanded a file-like object, then
> you wouldn't need to implement read_line, either.  Seek would also be a
> great thing to support, for skipping undesired records.  This option
> really makes the most sense to me.

I've discovered that for processing a 56K bundle, 95% of its time is
spent in BaseReader._readline.  It is called 946 times, resulting in 29,
914 calls to BaseReader.reader_func.

So I recommend fixing BaseReader._read_line, preferably by passing in a
file-like object.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGcq8m0F+nu1YWqI0RAkWhAJ9ducTqXEsQQYMMvasFzszz4E6VHQCZAWoO
YKbiNTWdCaae08RWT8UYIZ0=
=UQEQ
-----END PGP SIGNATURE-----



More information about the bazaar mailing list