trac: peerReview plugin and trac+bzr

Alexander Belchenko bialix at ukr.net
Fri Jun 15 15:39:34 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko пишет:
> Today I install and try plugin for Trac named PeerReviewPlugin
> http://trac-hacks.org/wiki/PeerReviewPlugin
> 
> Although plugin seems to work as expected, and I can prepare data
> for new review, I can't actually perform review.
> Every time I get error, and this text on page:
> 
> Internal Error
> No changeset u'mybranch' in the repository
> 
> 
> Here 'mybranch' is name of my branch under trac+bzr control.
> In this branch I selected some file for review.

After some digging I found that peer-review plugin incorrectly
understand changeset names generated by trac+bar.
I use Aaron's branch of trac+bzr, and as I can see, it's almost
the same as main trac+bzr branch. And this version of trca+bzr
produce name of changeset in form: <branch_name,revno>.
And peer-review plugin use revno after comma as first line number
of selected region for review.

I don't know what's the best way to solve this problem:
change trac+bzr to use another form of changeset names
or teach peer-review plugin to understand existing names.
May be the former is better, I just try to understand
why for trac+bzr use such form. Why not: <branch_name:revno>?
Or some other variant?

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGcqSlzYr338mxwCURAuqoAJ9ac9FCnt8jDWG1fw0hz9QeDHWmjwCeIIY4
8tumEIp36EdCbN+QQXFTLdQ=
=1tin
-----END PGP SIGNATURE-----



More information about the bazaar mailing list