[PATCH] Prefer lstat over stat, don't chmod symlinks

Aaron Bentley aaron.bentley at utoronto.ca
Tue Jun 12 16:21:22 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Elliot Murphy wrote:
> On 06/11/2007 07:40 PM, Martin Pool wrote:
> Sure thing! Here is an updated patch that includes tests for both
> make_readonly and make_writable, and verifies that they don't blow up
> when handed a dangling symlink.

Thanks.  The reason you don't see this on Bundle Buggy is because it's
not clear enough to BB that you're submitting a new merge request.  If
your email

a) is an initial email, not a reply (does not have Re:)
or
b) includes a patch as an attachment

then BB will recognize that it is a merge request.  And if b), it will
display the patch separately, with highlighting.

But because it's a reply, and the patch is inline, BB can't be sure this
is really a merge request.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGbrny0F+nu1YWqI0RAr5wAJ98D54T1ew1qUfHwwAuT7pZWvnOHQCfe/iE
MyA/+X9TEU8RNMXtql+6MTM=
=3S1M
-----END PGP SIGNATURE-----



More information about the bazaar mailing list