[MERGE] More than double the speed of "bzr selftest"
John Arbash Meinel
john at arbash-meinel.com
Tue Jun 12 00:41:04 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Martin Pool wrote:
> On 6/12/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
>> John Arbash Meinel has voted -0.
>> Status is now: Approved
>> Updating my vote because of interactions with sys.exit(). If those are
>> addressed, this looks good.
>> My only concerns are:
>> 1) leaving stuff cluttering $TEMP if the rmtree fails
> Thanks for catching that; I should have realized seeing as I did add
> the exit hack myself. Is it ok with you if I use Andrew's approach of
> explicitly running those hooks before we exit (assuming that works)?
- From reading the docstring it looks like it will. I'm not sure if this will
effect running time for commands.
>> 2) running out of path space on Win32 because IIRC, TEMP is in:
>> C:\Documents and Settings\<username>\Local Settings\Temp
>> However, if we are going to leave clutter, it is best to put it in '.'
>> or TEMP, so I'm okay with this.
> My current version of the patch actually does
> candidate_dir = tempfile.mkdtemp(dir=self.TEST_ROOT)
> so the top level directory names should be pretty small - 12
> characters or so. We may create something inside their that uses
> long paths, but that's probably a bug anyhow.
I would request that you add a prefix with something like "prefix='test-bzr' or
something to that effect. It is a lot more obvious if I see a lot of
directories with 'bzr' in the name, rather than 'tmpXXXX'
>> Ian- do you want this for 0.17? As a change to the test infrastructure I
>> consider it safe enough, but that is my personal opinion.
> I'll go along with Ian's decision to leave it until after 0.17 -- we
> should be branching today.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar