[MERGE] Faster commit

[Martin Pool]

On 6/4/07, Robert Collins <robertc at robertcollins.net> wrote:
> On Mon, 2007-06-04 at 15:12 +1000, Ian Clatworthy wrote:
> > The attached bundle speeds up commit, one of the areas of Bazaar most in
> > need of improvement for large trees. It has a noticeable impact: 50%
> > quicker for small commits and up to the same for the initial commit.
> >
> > In summary, the changes do the following:
> >
> > 1. buffer the report of commit messages until the end
>
> I'm still very much against this. -1

I'm not sure what the "still" refers, maybe an off list mail?

I haven't read the code but just making it buffered does seem like a
microoptimization to work around gnome-terminal.

Maybe we could write the changes to stdout rather than stderr, so it
is buffered?

We identified in London that doing complete and accurate "what was
committed" reports takes more significantly work than an optimal
commit.  (With our current commit code and format, the difference is
not so stark but I think it is still some more work.)  If we want to
be fast it's not so great to do extra work by default.  So perhaps the
changes should only be listed if you do commit -v, or at least
disabled by commit -q.

-- 
Martin