[MERGE][bug 115947] Fix DirState.set_state_from_inventory() for paths with common prefixes

Robert Collins robertc at robertcollins.net
Wed Jun 6 02:28:01 BST 2007


On Mon, 2007-05-21 at 13:44 +0200, John Arbash Meinel wrote:
+1

I think it might be nice to add cmp_paths_by_dir now? Or perhaps the
keys should be the split paths? Hmm, dunno :).

> It seems that DirState.set_state_from_inventory has a bug when
> handling 
> paths with common prefixes. (like a/b and a-b/).
> 
> It only happens when you have an inventory which modifies a record in 
> the shorter name, which will cause a mismatch when looking at the
> longer 
> one.
> 
> Attached is a bundle with a test case and a fix for it.
> 
> The bug has another possible fix, but this one seemed cleaner and
> easier 
> overall.
> 
> Also, if/when we bring in my DirState pyrex code, we can use 
> "cmp_paths_by_dir()" which does the same thing without having to
> split('/'). 
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070606/17aadb1a/attachment.pgp 


More information about the bazaar mailing list