[MERGE] Bugfix: WT4.get_file_sha1 raises exception on missing files #118186

[John Arbash Meinel]

John Arbash Meinel has voted +1.
Status is now: Approved
Comment:
One other small thing, you didn't 'bzr commit --fixes lp:118186', which 
is something we should try to do. However, the fact that you have to go 
through weird effort to fix this up after the fact hints at a problem 
with the UI for how '--fixes' works. Oh, and I usually include "Fixed 
bug #118616" in the commit message as well, so that you can "bzr log | 
grep". Or "bzr log -m 118186" to find the exact revision that mentions 
fixing a bug.

I doubt it was 22499, (maybe 2499 ?)

Anyway, good catch, +1 from me

I would typically do:

if e.errno == errno.ENOENT:
     return None
raise

rather than else: raise.

For me, it makes it clearer that it will raising is the default 
behavior.

But I'm certainly not picky on it.


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C4660239C.2010608%40utoronto.ca%3E