[MERGE] Faster commit
aaron.bentley at utoronto.ca
Thu May 31 01:23:36 BST 2007
Aaron Bentley has voted +1.
Status is now: Semi-approved
This is fine as an incremental improvement, but I don't like the way
we're invoking _note_before_complete unconditionally. If
ReportCommitToLog.deleted is invoked *after* ReportCommitToLog.complete,
then we'll invoke _note_before_complete *after* complete.
I may just have a naming neurosis, but absent a guarantee that
ReportCommitToLog.deleted cannot be invoked after
ReportCommitToLog.complete, I think it should be called _note_buffered
For details, see:
More information about the bazaar