[MERGE] Faster commit

Aaron Bentley aaron.bentley at utoronto.ca
Thu May 31 01:23:36 BST 2007


Aaron Bentley has voted +1.
Status is now: Semi-approved
Comment:
This is fine as an incremental improvement, but I don't like the way 
we're invoking _note_before_complete unconditionally.  If 
ReportCommitToLog.deleted is invoked *after* ReportCommitToLog.complete, 
then we'll invoke _note_before_complete *after* complete.

I may just have a naming neurosis, but absent a guarantee that 
ReportCommitToLog.deleted cannot be invoked after 
ReportCommitToLog.complete, I think it should be called _note_buffered 
or something.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C465BE3B7.2000609%40internode.on.net%3E



More information about the bazaar mailing list