[PATCH] faster initial commit due to buffered logging

[Ian Clatworthy]

Robert Collins wrote:
> On Mon, 2007-05-28 at 21:59 +1000, Ian Clatworthy wrote:
>   
>
> Logging stuff to ~/.bzr.log should be done where we think it will help
> debug problems. Specifically in this case, the actions are already
> logged to the console, so there is no need to also log them to
> ~/.bzr.log. I suggested switch to stdout because that will:
>  - remove the ~/.bzr.log output
>  - make commit more amenable to redirection
>  - put what is arguably the expected output of commit - the things its
>    doing - into stdout.
>
>
>   
I'm good with this - I just doesn't feel qualified to make a policy 
decision re what should and shouldn't go in ~/.bzr.log. Great to have 
you back!

I'll make sure I comment it clearly so someone doesn't come along later 
and put things back and 'fix' commit to update the log file.
>
> I like making the progress bar useful, but I dont think we need the
> complexity of your explicit buffering; rather lets just not write to
> ~/.bzr.log per-file-added. Also, the right place to buffer ~/.bzr.log,
> if we choose to do that, would be in the file itself: that way you wont
> change the ordering of things output to the file from different places
> in bzrlib, which would be a semantic change with confusing side effects.
>   

An excellent point. For consistency, "per file-added" needs to be 
"per-file" though, i.e. all the messages coming out of the CommitReporter.

Ian C.