[PATCH] faster initial commit due to buffered logging

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> The attached patch builds on the previous submitted one and includes
> better comments in response to feedback from Andrew Bennetts.

It would be nice to also see the overall changes, since this patch
appears to supersede your previous one*.  I'd like to suggest the
pattern I used for my "[MERGE] more common-ancestor performance
improvements": include a merge request or bundle with all the relevant
revisions, and a patch showing the new changes.  That way, people who
don't have your previous bundle can still merge.

> The main
> improvement though is "smarter" logging in that the "added ..." messages
> are output at the end, not in situ. To be strictly correct, the add
> messages are buffered until an 'interesting' one (like 'Committed
> revision xx.') is logged.

It seems like we should make it an error to invoke anything after
invoking CommitReporter.completed.  Do you agree?  (We'd have to start
by issuing DeprecationWarnings, I think.)

Also, it seems like it might make sense to use (and slightly extend)
delta._ChangeReporter for this, to unify the output formats.

*In fact, I'm not sure why BundleBuggy hasn't marked your previous one
"Superseded".

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGWu9s0F+nu1YWqI0RAjpDAJ9gnZcdciniWAyzf25MS7O4tvWiJwCdF/lJ
jijevQxH+ui3yfsIC8sHEA4=
=zyX1
-----END PGP SIGNATURE-----