[MERGE] (0.17) reworked LogFormatter API

[Kent Gibson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi John,

Can you point out where in PEP-8 is specifies that there must be space
in the cases you highlight?  The only section I can find relates to
not adding extraneous space.

Not that I have a problem with it if it is the bzr way, just I don't
see it in PEP-8.

>
>
> -    if show_merge is not None and show_merge_revno is None:
> +    legacy_lf = not getattr(lf, 'log_revision', None)
>
> I would also probably do this as:
>
> legacy_lf = getattr(...) is not None
>
I hope you mean:

legacy_lf = getattr() is None

And I prefer my way anyway - I think it reads better.

Cheers,
Kent.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGVYM0goxTFTi1P8QRAk9XAJsHZb3vdX1hgOG5o0cJUgiyeiLt6ACfRxOE
7sCa/Z8HYP0cGqxxXwE8uE8=
=Lmru
-----END PGP SIGNATURE-----