[MERGE] [BUG #4663] Fix ``bzr log -r`` to support selecting merge revisions.

Kent Gibson warthog618 at gmail.com
Sat May 19 02:47:13 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ooops, didn't mean for that diff to be picked up by BB.

Kent Gibson wrote:
>
>
> Aaron Bentley wrote:
>> Kent Gibson wrote:
>>> The attached bundle fixes filtering of revisions based on
>> revisionspec.
>>> `bzr log -rA` and `bzr log -rA..B` now work for all supported
>>> revisionspecs. That includes other log options such as <file>.
>> It seems like you've also removed the logic that swapped old and
>> new revisions if they were given in the wrong order.  Was that
>> deliberate?
>
> It's been a long time, but since it raises an exception and there
> is a unit test for it, I'd have to say it was definitely
> intentional. Assuming A < B, I felt that  by specifying -rB..A the
> user might be trying to control the ordering of the output.  That
> would conflict with the function of the --forward flag. I also felt
> that supporting implicit swapping of A and B in this case is
> confusing when considered along side open ended ranges like A.. and
>  ..B. So if it detects that condition it returns an error and
> points out that A < B. But I'm not fussed either way.  Obviously I
> felt more strongly about it at the time I coded it.
>
> It's easy enough to change to the original behaviour - just replace
>  the raise with a swap of the endpoints (diff attached).
>
> Let me know if there's anything else you'd like changed and I'll
> update my bundle.
>
> Cheers, Kent.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGTlchgoxTFTi1P8QRArz3AJ4krj/HbFrd00IoJZbvFYWC6G3HrQCeNP90
fWzy9QGkvttjYxRl9EcPn3Y=
=G+iw
-----END PGP SIGNATURE-----



More information about the bazaar mailing list