[RFC/MERGE] disabling kind markers for 'bzr status'

Aaron Bentley aaron.bentley at utoronto.ca
Fri May 4 18:53:12 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> That is fossil code.  We use ChangeReporter for short status now, and
>> that does use osutils.kind_marker.
> 
> For short status, but for long we still use the other code.

Yeah, I was somewhat confused-- the fossil code is the
short_status_letter stuff.

> At the very least, my plugin doesn't do anything for 'bzr status'
> without my patch.

When you're running status --short, as you originally described, it
ought to.

>>>> We could disable it with an ENV var, or we could make it a flag to
>>>> 'show_tree_status'. The flag would need to be propagated a bit, but not
>>>> terribly far.
>> You mean a flag to ChangeReporter I hope?
> 
>> Aaron
> 
> I don't think we use ChangeReporter as much as you think we do.

I was confusing show_tree_status with TreeDelta.show.

> Regardless, the flag has to be on 'show_tree_status' because that is
> being called from 'cmd_status.run()'. Whether the final *user* is
> ChangeReporter or TreeDelta.show() that is the "it must be propagated a
> bit".

ACK.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGO3MI0F+nu1YWqI0RAuZhAJ9P6K0tpaHvCtGGwAqmwthe403iNQCfX4ZL
7H9MLp1i5nXvKRRp68mnaTQ=
=urub
-----END PGP SIGNATURE-----



More information about the bazaar mailing list