[MERGE][0.16][bug #111127] Properly handle 'a/' and 'a-b' directories

Marius Kruger amanic at gmail.com
Fri May 4 06:18:28 BST 2007


hi,

On 4/30/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> It turns out that our path iterator code has some problems when we have
> paths with '-' in them. This is because "a/b" sorts after "a-X", but
> ('a', 'b') sorts before ('a-X',).

If I understand correctly,
this is not the only place where we can have problems!

transform:768 TreeTransform._apply_removals
workingtree:1812 WorkingTree.remove    (which I copied from the above:)

Since we could reuese this, I suggest we add a nice utility to osutils
to do this like
osutils.reverse_tree_sort(file_names)


regards
marius



More information about the bazaar mailing list