[MERGE][0.16] temp file for commit message in external editor should be opened in text mode (#110901)

Alexander Belchenko bialix at ukr.net
Tue May 1 03:45:42 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> John Arbash Meinel has voted -0.
> Status is now: Approved
> Comment:
> Please wait before merging.
> I don't have time to do a full review but there is some cruft in the tests.
> 
> v-- This is really ugly, and we should find a better way to wrap the lines.
> 
> +        msgfilename, hasinfo = bzrlib.\
> +                               msgeditor.\
> +                               _create_temp_file_with_commit_template(
> +                                    'infotext', '----', 'start message')

It's for keep lines shorter than 80 chars.
If you say it's ugly...
I could use shorter variable names, and shorter name for function
under test.
And importing

from bzrlib import msgeditor

it's also shorten a bit.


[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGNqnWzYr338mxwCURAqSeAJ0c0RLUZuXanWbhSTjqrCFEvmXRGgCgjzXk
YHPYfNyJzqIAw0foxoFcXsA=
=N4i6
-----END PGP SIGNATURE-----



More information about the bazaar mailing list