Whats the difference between annotate and tree.annotate_iter ?

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I'm not clear what annotate.py is attempting to do. Is it a UI layer on
> top of trees?

That is how I view it.  It is not used by gannotate.

> (in which case its poking way to deep under the hood)

Yes, but it was written before tree.annotate_iter existed, so there
wasn't a better alternative.

> I *think* that annotate.py is really 'text ui output for annotation' and
> as such should take an annotate_iterator rather than calling into the
> repository itself.

Seems reasonable.

> Really though I think the API needed for the text ui should be more
> properly on Tree, so that we can find bugs in annotations with different
> tree representations via our parameterised tests.

I don't understand what you mean.  Even if we put annotate_file on Tree,
it wouldn't vary.  What varies is the implementation of
Tree.iter_annotate, so that's what we should be testing.  And we already
can.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGMX7P0F+nu1YWqI0RAmTQAKCG8uAtqacRzPI5ZdouE1WzremkBgCfSwje
60YuULRRCAOwCBkIRxNNHnA=
=mTmb
-----END PGP SIGNATURE-----