[MERGE][0.16][bug #110399] 'bzr status' and 'bzr diff' shouldn't recurse into unknowns

John Arbash Meinel john at arbash-meinel.com
Fri Apr 27 03:07:07 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Thu, 2007-04-26 at 18:08 -0500, John Arbash Meinel wrote:
>> Does anyone know of a better way to test this? 
> 
> what about a symlink cycle within the subtree that we're not meant to be
> processing?
> 
> or use bzrlib.strace to see what paths are accessed ? Less portable but
> should be robust :).
> 
> -Rob

We don't follow symlinks (since we generally use os.lstat), so a cycle
wouldn't do anything.

strace might work, but it would mean parsing the output, and I don't
know if strace is stable on all platforms.

It also requires having strace available, and I know it isn't on my Mac
(it might be a simple port install away, though).

Since we don't seem to have a better way, do you have a vote for the patch?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGMVrLJdeBCYSNAAMRAkrbAKDLl9p12cNwXYBTtkrH/J7JhH0I6gCglLQy
cGO/osJKgSasG11p/v2oF+8=
=Lyj+
-----END PGP SIGNATURE-----



More information about the bazaar mailing list