Bug in dirstate _iter_changes

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Aaron Bentley wrote:
>>> John Arbash Meinel wrote:
>>>> Aaron Bentley wrote:
>>>>> But iter_changes appears to sometimes recurse into unversioned
>>>>> directories, and if it doesn't have permission, it crashes.
>>>> Can you try it after my patch for:
>>>> http://bzr.arbash-meinel.com/branches/bzr/0.16-dev/iter_changes_unknowns_104257
>>> That fixed it.  Great!
> 
> I'm still seeing brokenness on this tree for "bzr diff".  I'm using
> bzr.dev revno 2456, and getting
> 
> bzr: ERROR: exceptions.OSError: [Errno 13] Permission denied:
> '/home/abentley/configs/web//forms2.r7-6-3/tmp/ziptempAp5BkA'
> 

...


> 
> bzr 0.16.0dev0 on python 2.4.1.final.0 (linux2)
> arguments: ['/home/abentley/bin/bzr', 'diff', '-Derror']
> 
> Repeat: status works, but diff does not.
> 
> Aaron

Here is another possible patch. In this case, it just moves the "if
want_unversioned" inside the loop, rather than having 2 loops.

It should have the same ultimate effect. It just means evaluating the if
more often. But the code is a little easier to understand.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGL9BwJdeBCYSNAAMRAuQPAKC15N7kWu5W9NKtXAcIHGmKe742EACfbt4U
sPmCFBIV7DJRLXrEUzR/Sj0=
=cseE
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff_no_unknowns.diff
Type: text/x-patch
Size: 2418 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070425/3e0cf41d/attachment.bin