[MERGE][0.16] fix problem with SIGQUIT on win32

Martin Pool mbp at sourcefrog.net
Wed Apr 25 05:08:59 BST 2007


On 4/25/07, Alexander Belchenko <bialix at ukr.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> This patch fixes this problem introduced by recent patch from Martin.

Sorry.

> C:\Temp\win32.fixes>python bzr
> Traceback (most recent call last):
>   File "bzr", line 77, in <module>
>     bzrlib.breakin.hook_sigquit()
>   File "C:\Temp\win32.fixes\bzrlib\breakin.py", line 41, in hook_sigquit
>     signal.signal(signal.SIGQUIT, _debug)
> AttributeError: 'module' object has no attribute 'SIGQUIT'

+1 on that, but maybe it would be better to check whether there is a
sigquit in the signal module instead?

=== modified file 'bzrlib/breakin.py'
--- bzrlib/breakin.py	2007-04-24 04:51:31 +0000
+++ bzrlib/breakin.py	2007-04-25 04:08:49 +0000
@@ -38,4 +38,6 @@
     # XXX: is this meaningful on Windows?
     if os.environ.get('BZR_SIGQUIT_PDB', '1') == '0':
         return
+    if getattr(signal, 'SIGQUIT', None) is None:
+        return
     signal.signal(signal.SIGQUIT, _debug)


-- 
Martin



More information about the bazaar mailing list