[BUG][0.16 blocker] pull doesn't know about '_run_hooks'

[John Arbash Meinel]

I'm trying to sort out the code in question, but I just did:

$ cd jam-integration
$ bzr pull ../bzr.dev

and got (and a traceback):

bzr: ERROR: exceptions.TypeError: pull() got an unexpected keyword
argument '_run_hooks'

I think the problem is that I'm using a checkout of a "bzr+ssh://"
branch, and the "branch-hooks" updates weren't taught to the new smart
server code.

It seems to be that the base implementation does not have "_run_hooks"
as a parameter, and neither does "RemoteBranch".

Further, "BzrBranch" also has a "_hook_master" variable. I don't know
how this should be passed around, since BzrBranch5 does *not* have that
parameter.

I think the failure is that Branch.pull() seems to assume that the
master is of the same format as current, so we expected that we could
update the local with a private variable and pass it around.

However, we can't, because master may be a completely different branch
(it could be an SVN branch, for example).

The *easy* fix is to just add "_run_hooks" on the RemoteBranch.pull(),
but that doesn't seem like the correct fix.

Thoughts?

John
=:->