[MERGE] bzr rm should delete the working file (Bug #82602)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius Kruger wrote:
> hi,
> 
> this morning  I looked at my blackbox tests with fresh eyes, and I
> realised that I had to improve them a little.
> This bundle does not change any functionality from the previous one,
> but it tests a bit better.
> 
> sorry for the many bundles.
> 
> regards
> marius
> 

- -0 (for now)

The only part I don't like is the "magic" for taking

self.run_bzr('command to run')

There are a few issues... The biggest being that shlex.split() doesn't
support Unicode arguments.

I'm not sure if the others caught that you changed this, but it is
something that we haven't done (in favor of being very explicit about
what arguments are being passed by run_bzr).

I would rather something like this wasn't "snuck-in" without discussion
on a merge for "bzr rm".


(I'm not strictly opposed to the change, though I'm a little negative on
it. I am opposed to it being merged without discussion).

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGJ88cJdeBCYSNAAMRAjuOAJ0cBJ21WG/uOKLo4kwFckd3sObo7wCfaeT/
ehxEGQFUrEA0kPbZe5rV8IA=
=Worm
-----END PGP SIGNATURE-----