[RFC] help logic for commands should be a Command method?

[John Arbash Meinel]

Martin Pool wrote:
> On 4/19/07, Robert Collins <robertc at robertcollins.net> wrote:
>> Well that about says it all - I think the logic in bzrlib/help.py that
>> relates to commands would be better suited as 'Command.help_text' or
>> some such method.
> 
> +1
> 

Isn't it?

I see:

bzrlib/commands.py line 311:

class Command
...

   def help(self):
        """Return help message for this class."""
        from inspect import getdoc
        if self.__doc__ is Command.__doc__:
            return None
        return getdoc(self)

Are you saying that the "help_on_command" logic should be rolled into that?

I'm ambivalent on it. Because it is helpful, but if we have html help it
would be nice to have a formatter which can do the "extra" stuff in a
fancy html fashion...

John
=:->