[PATCH] test_timestamp.py changes for win32
Martin Pool
mbp at sourcefrog.net
Thu Apr 19 07:14:09 BST 2007
On 4/19/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
> Specifically there are timezones which are shifted by fractional hours.
> (+10.5 in India, IIRC). We ran into other bugs with our timestamp
> formatter related to these.
>
> The standard way is: HHMM, which is (offset / 3600), ((offset / 60 )% 60)
>
> You seem to be using seconds / 36 which gives 1150 as the TZ offset
> instead of 1130. (11.50 hours versus 11hrs 30min).
You're right, format_patch_date and parse_patch_date are definitely
wrong in how they format the timezone.
Am I correct in thinking that we don't really care about supporting
times before the epoch in general, just that we can format the epoch
timestamp for use with added or removed files? Maybe we could always
format 0 as gmtime? After all they're really just saying "null
timestamp" not that particular date in 1970.
This patch does those two things.
--
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff.tmp
Type: application/octet-stream
Size: 2458 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070419/0e816d9a/attachment.obj
More information about the bazaar
mailing list