[PATCH] test_timestamp.py changes for win32
aaron.bentley at utoronto.ca
Wed Apr 18 23:49:18 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Alexander Belchenko wrote:
>>> This test is not checking negative dates. 1969-12-31 19:00:00 -0500 is
>>> 1970-01-01 0:00:00 +0000, and we ought to be able to represent that on
>>> all platforms. So win32 seems to be broken (admittedly on an edge case.)
>>>> We shouldn't avoid the test on platforms where it succeeds. and
>>>> "knownFailure" gives us a way to say "yeah, this doesn't work on this
>>> I think KnownFailure is meant to reflect a bug in our code. A
>>> KnownFailure should always fail. It is an error for such a test to
>>> succeed when we expect it to fail.
>>> Since it relates to platforms, UnavailableFeature seems more appropriate.
> Here the patch with GmtimeNegativeSecondsFeature.
> Can someone check this patch on Linux?
> (python bzr --no-plugins selftest test_timestamp -v)
Having looked at the implementation, I don't think that win32 is broken
at all. I think the implementation is broken, but only win32 reveals
the bug. Any timestamp on or after the epoch should not cause us to
call gmtime with a negative value.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar