[RFC] Conditionalize format warnings

[Matthew D. Fuller]

On Wed, Apr 18, 2007 at 04:15:16PM -0500 I heard the voice of
John Arbash Meinel, and lo! it spake thus:
> 
> It seems odd to me to have "BzrDir.open_workingtree()" have an
> internal side effect of opening a branch (which is likely already
> open) and then checking whether that Branch claims to have
> "recommend_upgrade" silenced.

Well, to me too, but the other choice was either not allow any local
configurability, or massive API rototilling.  I opted to actually make
the change.


> If you just need the name you can use:
> 
> branch.control_files.controlfilename('branch.conf')

That'll work.  Changed.


> Are you sure that you actually need _get_filename()? Since you can't
> actually open that path.

Without it, you get an error message saying "Hey, this config param
has an invalid value.  Nope, I'm not gonna tell you WHERE the invalid
entry is, just that there's one somewhere.  Nyah nyah nyah."  Not very
Safe or Friendly.


-- 
Matthew Fuller     (MF4839)   |  fullermd at over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.