[rfc] time.gmtime() does not accept negative numbers on win32

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Alexander Belchenko wrote:
> self.assertEqual('1969-12-31 19:00:00 -0500',
>                  timestamp.format_patch_date(0, -5 * 3600))
> 
> It could easily be that this test wants to test how we handle negative
> dates. (Just in case someone converts old code that is pre 1970).

This test is not checking negative dates.  1969-12-31 19:00:00 -0500 is
1970-01-01 0:00:00 +0000, and we ought to be able to represent that on
all platforms.  So win32 seems to be broken (admittedly on an edge case.)

> We shouldn't avoid the test on platforms where it succeeds. and
> "knownFailure" gives us a way to say "yeah, this doesn't work on this
> platform".

I think KnownFailure is meant to reflect a bug in our code.  A
KnownFailure should always fail.  It is an error for such a test to
succeed when we expect it to fail.

Since it relates to platforms, UnavailableFeature seems more appropriate.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGJj5m0F+nu1YWqI0RAlviAJ0dT8Z7KggKvgMPFr5ZhCn1xH6b/gCfS+tw
mpyaegy1TURxQqSlOgrwYDI=
=8DWB
-----END PGP SIGNATURE-----