[MERGE] Support FTP servers with non-atomic rename (bug #89436)
bialix at ukr.net
Wed Apr 18 05:04:14 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Aaron Bentley пишет:
> Alexander Belchenko wrote:
>> Aaron, with your patch merged I have much more failing FTP tests on win32 than before.
>> Now I have 33 failed tests (60 total count).
> Sorry about that. I will fix it. It appears to be breaking because we
> aren't getting a useful exception when a rename fails, but since I force
> the error, I'm surprised it's not the same on *nix and win32.
It's strange, but I have errors in Ftp tests only with Python2.5,
but not with Python2.4. And probably because error handling in Medusa(?)
expect special format of python exception message. Because in Python 2.5
these messages looks slightly different.
In the test.log I see following:
_ftp_channel: ==> 550 RNTO failed: [Error 2]
unable to understand error for path: /from/dir/foo: 550 RNTO failed: [Error 2]
_ftp_channel error: uncaptured python exception, closing channel <bzrlib.transport.ftp.ftp_channel
connected 127.0.0.1:3425 at 0x231ab48> (<class 'socket.error'>:(10038, 'Socket operation on
non-socket') [C:\Python25\lib\asynchat.py|handle_read|89] [C:\Python25\lib\asyncore.py|recv|342])
This message: 'unable to understand error for path' looks suspicious.
IIRC, in Python 2.4 exception message reports error number as [Errno 2].
So, Aaron, I think with your patch is all OK, sorry for my complains.
But something wrong with Medusa on Python2.5.
Is Medusa is still maintained or it's a dead project?
Or maybe this difference between 2.4 and 2.5 will be fixed in 2.5.1...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar