[MERGE] tags in log output

[Kent Gibson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Alexander Belchenko wrote:
>
> I'd like to use kwargs, because creating new object for each
> revision could leads to slowdown without any real benefit. We can
> document all new parameters (expected in kwargs) for log formatter
> in the API docstrings.
>
After all the other crud log.py has waded through to work out what
revisions to log, I seriously doubt an extra class creation per
revision would make any noticeable difference to the speed.

I agree the params could also be documented in either the method
itself, or in the API in general.  I haven't actually paid much
attention to how bzr code is documented so I don't have much to base
an opinion on, though I probably have a stronger bias toward using
classes than the average bzr developer.

I'd be interested to know if one approach has an edge wrt marshalling
the params by show_log and demarshalling them by the LF, as measured
by code simplicity and efficiency.
I suspect the two are equivalent, and lean towards using a class cos I
feel provides a cleaner encapsulation than a kwargs dict, and allows
us to add helper methods to LogRevision that may otherwise end up
being replicated in the log formatters themselves.

Cheers,
Kent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD4DBQFGH1VCgoxTFTi1P8QRAk5uAJ96vm3Bs3ST5Jv91nd3FvqkX9S9VgCWOfWf
lsaawyeQbFT1SA1C+gOBgQ==
=3uq2
-----END PGP SIGNATURE-----