[MERGE] Initial support for marking bugs as fixed using bzr

[Jonathan Lange]

On 4/13/07, James Westby <jw+debian at jameswestby.net> wrote:
> On (11/04/07 14:43), Jonathan Lange wrote:
> > Adds a '--fixes' option to commit to allow users to specify that the
> > commit fixes certain bugs. Bugfix information is stored as <bug_url>:
> > <status> entry in the properties dict.
> >
> > Based on discussions w/ lifeless and jamesh at the recent Sydney
> > mini-sprint.
> >
>
> Hi,
>
> This looks good.
>
> I have a couple of points.
>
> Is it possible to set the default tracker for a branch? This would allow
> --fixes 12345 to do the right thing, but --fixes lp:21345 to be used if
> wanted?
>

I think it is both possible and desirable. However, I think that
feature is best added in another merge.

> Also I have added bugs.debian.org, with the tag 'deb'. I'm not sure that
> it is the correct tag, but it will do. Also b.d.o allows you to use the
> #21345 in the URL and the redirect will work, so that could be allowed
> but isn't. I have added two classes to help with adding new trackers. If
> you have a tracker where a bug_id is just appended to a base URI then
> subclass the first and add attributes for the tag and base_url. The
> second is the same but ensures the bug_ids are integers. I moved lp over
> to the second as well.
>

Thanks, I like this.

I've taken the liberty of renaming "Simple" to "Unique", to better
reflect the use case. I've also changed 'Bugtracker' to 'BugTracker'
in class names, since it is properly two words.

> Would it be possible to take these and make it easy to use a new one
> that is simple like these. Like you do with the trac URLs, but just
> define a generic URL. I wasn't sure on the best approach, so I thought I
> would ask first.
>

I'm also not sure of the best approach, but think this would be a good idea.

> Did all the tests pass for you? I had a couple of problems, namely the
> Option tests, where it appears the ListOption was causing some trouble.
>

Oops, no they didn't. test_options assumes things about the options
taken by 'bzr commit'. Fixed now.

cheers,
jml