[MERGE] tags in log output

[Kent Gibson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



Aaron Bentley wrote:
> Kent Gibson wrote:
>> Hi Alexander,
>
>> I've got a comment that isn't specific to your patch, it's more
>> about plugin APIs in general, but your patch is a specific
>> example.
>
>> Rather than changing the LogFormatter API every time some new
>> detail is added to a revision (tags in this case, the delta for
>> merge revs in a recent patch from JAM), wouldn't it be better to
>> make the tags an attribute of the revision itself?
>
> I don't think so.  Anything that is not part of the revision should
> not be added to it, because revisions are supposed to be immutable.
>
>
> Therefore, revno and dotted revno should not be made attributes of
> revisions.  You might provide a supplemental dict, or maybe
> **kwargs, though.
>
Actually I was thinking of a wrapper class - LogRevision which would
contain the attributes to be logged - including the revision, revno,
delta, tags, ...
I guess kwargs would serve the same purpose, but a class can be
documented so you know what attributes to expect.

I agree we don't want to change revision itself, for the reasons you
mention.

Cheers,
Kent.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGHtJAgoxTFTi1P8QRAqPRAKCqAAI7zm9C2YTgc7npz41OphNBcwCeLA3l
EJPjGTn88szQyntaPZ1YlwY=
=t9cz
-----END PGP SIGNATURE-----