[MERGE] tags in log output

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Kent Gibson wrote:
> Hi Alexander,
> 
> I've got a comment that isn't specific to your patch, it's more about
> plugin APIs in general, but your patch is a specific example.
> 
> Rather than changing the LogFormatter API every time some new detail
> is added to a revision (tags in this case, the delta for merge revs in
> a recent patch from JAM), wouldn't it be better to make the tags an
> attribute of the revision itself?

I don't think so.  Anything that is not part of the revision should not
be added to it, because revisions are supposed to be immutable.

Therefore, revno and dotted revno should not be made attributes of
revisions.  You might provide a supplemental dict, or maybe **kwargs,
though.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGHkcP0F+nu1YWqI0RAlLbAJ9nrBTPYxyoJuZDjtbApuhwHO1qsgCeOBN6
IlI+dwh63xFj/owOK1mN+Yg=
=Rapl
-----END PGP SIGNATURE-----