[MERGE] tags in log output
bialix at ukr.net
Thu Apr 12 12:09:57 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Erik Bågfors пишет:
> On 4/11/07, Alexander Belchenko <bialix at ukr.net> wrote:
>> Erik Bågfors пишет:
>> > Here is an updated version, based on input from you guys.
>> I think some moments could be slightly reworked:
>> === modified file 'bzrlib/log.py'
>> - --- bzrlib/log.py 2007-04-11 01:04:57 +0000
>> +++ bzrlib/log.py 2007-04-11 09:14:28 +0000
>> @@ -273,7 +273,7 @@
>> delta = None
>> if use_tags:
>> - - lf.show(revno, rev, delta, rev_tag_dict.get(rev_id,
>> + lf.show(revno, rev, delta, rev_tag_dict.get(rev_id))
> Ahh.. true, for a while that didn't work, but I changed that code.
> Guess I should rather change it to rev_tag_dict[rev_id] ?
No, the latter will raise KeyError, and thus unacceptable.
>> I'm also think that this code is somewhat superfluous:
>> + if use_tags:
>> + lf.show(revno, rev, delta, rev_tag_dict.get(rev_id, ))
>> + else:
>> + lf.show(revno, rev, delta)
>> I'd like to have it unconditional, but I understand pros and cons.
>> So I can live with that approach.
> The only reason to have that was to not break the API for old log plugins.
I understand this point.
> I'm very busy right now, and am going to Vegas in a few days, so I
> will not have time to care for this in a few weeks. Feel free to
> rework this (applying this patch and anything else you need to do) and
> submitt it for review again if you want.
OK. I'd like it see merged in 0.16.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar