[MERGE] get_file_mtime tests

Robert Collins robertc at robertcollins.net
Thu Apr 12 02:26:04 BST 2007


On Wed, 2007-04-11 at 16:36 -0500, John Arbash Meinel wrote:
> This patch just cleans up the existing 'get_file_mtime()' test, and adds
> a couple more tests for WorkingTrees to make sure they properly handle
> files which have been moving around.
> 
> I wrote them while trying to track down:
> https://bugs.launchpad.net/bzr/+bug/103870
> 
> But it turns out the bug is specifically in the diff code (it is passing
> a path for 'old', when a file is just 'modified', not realizing the file
> isn't at that path, because the containing directory has been renamed.)
> 
> I'm working on a real fix for the other, but I figured these tests were
> good to have.

I think that passing the old path in from diff is fine: the bug is in
get_file_mtime not checking that the path hint was correct: it should
ensure it finds the right id before completing.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070412/e0cacb34/attachment.pgp 


More information about the bazaar mailing list